-
Notifications
You must be signed in to change notification settings - Fork 11
Use generator local targetV if set as local regulation #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1240cd1 to
6bdec1c
Compare
6250ea7 to
4ae5029
Compare
…RemoteControl=false Signed-off-by: Didier Vidal <[email protected]>
…RemoteControl=false Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
8581251 to
54769aa
Compare
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
| if (disableInconsistentVoltageControls && Math.abs(localTargetV - genLocalTargetV) > TARGET_V_EPSILON) { | ||
| return Double.NaN; | ||
| } | ||
| // else if !disableInconsistentVoltageControls keep the first voltage target found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a warn log/report when detecting inconsistent voltage control (precising if this local voltage control is taken into account or not regarding the parameter disableInconsistentVoltageControl) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. It also joins a remark from Damien that challenged the new equivalentTargetV API in lfGenerator.
I refactored in order to keep only one targetV and reuse all existing check mechanisms.
src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
Outdated
Show resolved
Hide resolved
| olf.reactiveControllerBusesToPqBuses = ${remoteReactivePowerControllerBusToPqCount} noeuds électriques avec régleur de puissance réactive à distance passé(s) en PQ | ||
| olf.reactiveControllerBusesToPqMaxQ = Réglage de la puissance réactive distante du noeud électrique '${busId}' -> PQ, q=${busQ} > maxQ=${maxQ} | ||
| olf.reactiveControllerBusesToPqMinQ = Noeud électrique ${busId} régleur de puissance réactive à distance -> PQ, q=${busQ} < minQ=${minQ} | ||
| olf.rescaledRemoteVoltageControls = ${count} contrôles de tension distants n'ont pas de consigne équivalente locale et passent en réglage local par mise à l'échelle de la tension nominale locals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mise à l'échelle de la tension nominale locale."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done.
…oaderImpl.java Co-authored-by: Sylvestre Prabakaran <[email protected]> Signed-off-by: vidaldid-rte <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
) Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
|



Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#1268
NOTE:
This PR depends on powsybl/powsybl-core#3635 (review)
What kind of change does this PR introduce?
If a generator is configured for remote voltage control but needs to turn local for any reason and if a local target v is defined, that value is used instead of keeping the same pu target.
Reasons for tunring remote to local include:
parameter voltageRemoteControl set to false
consistency checks in OLF that switch a remote voltage control to a local voltage control
What is the current behavior?
When a generator is moved to local voltage control the remote target in pu is kept locally
What is the new behavior (if this is a feature change)?
If a local target has been defined (by a state esimator or any other process in charge of coputing voltage target) that value is used instead.
Does this PR introduce a breaking change or deprecate an API?